Skip to content

Tweak irrefutable let else warning output#154325

Open
WeiTheShinobi wants to merge 1 commit intorust-lang:mainfrom
WeiTheShinobi:tweak-let-else-output
Open

Tweak irrefutable let else warning output#154325
WeiTheShinobi wants to merge 1 commit intorust-lang:mainfrom
WeiTheShinobi:tweak-let-else-output

Conversation

@WeiTheShinobi
Copy link
Copy Markdown
Contributor

@WeiTheShinobi WeiTheShinobi commented Mar 24, 2026

Fixes #153454

Greeting!
This PR tweak diagnostic output for irrefutable-let-else patterns and adds a check for let a = Some(b) else {...}
Thanks for the review!

help: consider using `let Some(name) = case` to match on a specific variant
   |
LL -     let name = Some(case) else {
LL +     let Some(name) = case else {
   |

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 24, 2026

Some changes occurred in match checking

cc @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 24, 2026

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 13 candidates

@WeiTheShinobi WeiTheShinobi force-pushed the tweak-let-else-output branch from f9c1661 to 94d6023 Compare March 24, 2026 17:06
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WeiTheShinobi WeiTheShinobi marked this pull request as draft March 24, 2026 17:48
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2026
@WeiTheShinobi WeiTheShinobi force-pushed the tweak-let-else-output branch from 94d6023 to 254a0c7 Compare March 28, 2026 17:56
@WeiTheShinobi WeiTheShinobi marked this pull request as ready for review March 28, 2026 20:01
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@WeiTheShinobi WeiTheShinobi force-pushed the tweak-let-else-output branch from 254a0c7 to adc87de Compare April 1, 2026 12:54
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 1, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davidtwco davidtwco

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tweak irrefutable let else warning output

4 participants

@WeiTheShinobi @rustbot @rust-log-analyzer @davidtwco